fix(hono): Use generic Hono type in Bun/Node#21060
Merged
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
chargome
approved these changes
May 20, 2026
andreiborza
approved these changes
May 21, 2026
Member
|
Thanks for the extra test, nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the generic type for
sentry()and also adds some additional tests for the case mentioned in the attached issue.The below attached issue also described that mounting
sentry()as middleware broke.get()routes used by third-party libraries likehono-openapiand@scalar/hono-api-reference(which was fixed in #20954). Previously, Hono's internals were patched in a way that corrupted route state. The current version usesProxy+Reflect.applyfor all patches, which preserves the routing table intact and doesn't touch.get()at all.Closes #21019